Conan v1 pipeline ✔️

All green in build 1 (31bbbd8f299d2de6cac6df4a22290d185b3af8aa):

• vswhere/3.1.7:
  All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 1 (31bbbd8f299d2de6cac6df4a22290d185b3af8aa):

• vswhere/3.1.7:
  All packages built successfully! (All logs)

Is it possible to not have this tool at all on machines with VS installed?

vswhere is included with the installer as of Visual Studio 2017 version 15.2 and later, and can be found at the following location: %ProgramFiles(x86)%\Microsoft Visual Studio\Installer\vswhere.exe

Is it possible to not have this tool at all on machines with VS installed?

vswhere is included with the installer as of Visual Studio 2017 version 15.2 and later, and can be found at the following location: %ProgramFiles(x86)%\Microsoft Visual Studio\Installer\vswhere.exe

Ah, good point. I missed that fact. It was not found on PATH when building NSS, though, despite VCVars being activated. Might need additional setup.

I would still add it as a CCI package. vswhere is guaranteed to be installed only on VS 2017 / 15.2. It's normally not found on PATH, though. The recipes will need to include env.append_path("PATH", r"C:\Program Files (x86)\Microsoft Visual Studio\Installer") for it to be found. And event then it feels a bit fragile.

See also: https://github.com/Microsoft/vswhere/wiki/Installing

Agreeing with @Nekto89 here - note that Conan 2 supports VS2017 and newer - and that vswhere is unconditionally installed by the installer in that location (irrespective of where visual studio itself is installed) - don't think it's worth it.

I'm not aware of any installation process of vswhere where it ends up in PATH - so it may be worth checking with the nss developers, https://github.com/nss-dev/nss/blob/NSS_3_104_RTM/coreconf/msvc.sh#L47-L48 - i suspect this should refer to the file with its full path

On the other hand, looking at the NSS scripts - it is using vswhere to manually set up the variables that the vcvars script would otherwise do - this could cause two issues:

• if vcvars is already "loaded" (that is, LIB, INCLUDE vars is already defined) - these variables will either be overwritten or appended/prepended
• it picks up the "latest" that vswhere finds - instead of the one specified by the user in the Conan profile.

It may be safest to let Conan bring up the vcvars, and simply define GYP_MSVS_VERSION, VSPATH and GYP_MSVS_OVERRIDE_PATH in the recipe - and don't let the nss script invoke vswhere at all

Sounds reasonable. I'll look into getting rid of the vswhere dep in nss.